Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register all REPLs and make SPC m ' bindings #4826

Closed
wants to merge 1 commit into from

Conversation

TheBB
Copy link
Collaborator

@TheBB TheBB commented Jan 26, 2016

Complete #4600 and implement #2029.

@@ -52,6 +52,8 @@
:commands (R stata julia SAS)
:init
(progn
(spacemacs/register-repl 'ess-site 'julia)
(spacemacs/register-repl 'ess-site 'spacemacs/ess-start-repl "ess")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spacemacs/ess-start-repl won't do what we want it to here. It only works if a buffer is already open in ESS mode. Instead each REPL provided by ESS should be registered separately, i.e.,

      (spacemacs/register-repl 'ess-site 'julia)
      (spacemacs/register-repl 'ess-site 'R)
      (spacemacs/register-repl 'ess-site 'SAS)
      (spacemacs/register-repl 'ess-site 'stata)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'll get to it later today!

@syl20bnr
Copy link
Owner

syl20bnr commented Feb 1, 2016

Thank you 👍
I added the separate registration of REPLs for ESS but I did not add bindings to them.
Cherry-picked into develop branch, you can safely delete your branch.

@syl20bnr syl20bnr closed this Feb 1, 2016
@TheBB TheBB deleted the shells branch February 1, 2016 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants